[llvm] r298652 - Move spill size and alignment info from MC to TargetRegisterInfo

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 13:12:55 PDT 2017


> On Mar 24, 2017, at 12:51 PM, Krzysztof Parzyszek <kparzysz at codeaurora.org> wrote:
> 
> On 3/24/2017 2:44 PM, Quentin Colombet wrote:
>> Of course! Like I said, I believe the patch you suggested looks good
>> modulo keeping the MC getSize piece and renaming the TRI getSpillSize.
> 
> That will not work very well.  Register size, spill slot size, spill slot alignment and MVTs associated with a register class will all be dependent on subtarget flags.  Putting any of it in MC at this point is going to have a significant impact on the design, let alone all the work I have done so far.

We might have a misunderstanding.

I was suggesting to put everything in TRI but the register size. That being said, take it with a grain of salt, I reckon I haven’t read any of the patches/discussions that have been going on that topic.

> 
> -Krzysztof
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation



More information about the llvm-commits mailing list