[PATCH] D31316: [PDB] Split item and type records when merging type streams

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 24 10:13:32 PDT 2017


rnk marked 2 inline comments as done.
rnk added inline comments.


================
Comment at: lld/COFF/PDB.cpp:118
 
     BinaryByteStream Stream(Data, llvm::support::little);
     codeview::CVTypeArray Types;
----------------
Remove `llvm::` here as well?


================
Comment at: llvm/tools/llvm-readobj/ObjDumper.h:13
 
+#include "llvm/ADT/StringRef.h"
 #include <memory>
----------------
ruiu wrote:
> Do you need this?
Not anymore.


https://reviews.llvm.org/D31316





More information about the llvm-commits mailing list