[PATCH] D31236: Refactor getHostCPUName to allow testing on non-native hardware.
Kristof Beyls via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 24 07:42:46 PDT 2017
kristof.beyls updated this revision to Diff 92944.
kristof.beyls edited the summary of this revision.
kristof.beyls added a comment.
- By refactoring a little bit more, it became possible to test using a regular unit test, not having to use a mock, which makes the test a lot cleaner.
- During review discussions with Hal, it become clear that it's probably best to stick to unit testing rather than using lit-based testing for this feature.
https://reviews.llvm.org/D31236
Files:
include/llvm/Support/Host.h
lib/Support/Host.cpp
unittests/Support/Host.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31236.92944.patch
Type: text/x-patch
Size: 18081 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170324/ff67a0a5/attachment.bin>
More information about the llvm-commits
mailing list