[llvm] r298700 - Remove stale and unused (MC)TargetOptions comparators.
Teresa Johnson via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 24 05:50:47 PDT 2017
Author: tejohnson
Date: Fri Mar 24 07:50:45 2017
New Revision: 298700
URL: http://llvm.org/viewvc/llvm-project?rev=298700&view=rev
Log:
Remove stale and unused (MC)TargetOptions comparators.
Summary:
I discovered accidentally that the operator== for TargetOptions
is stale - it is missing many fields that have been added over
the recent years. It isn't used, so remove it. Ditto for the
comparator in MCTargetOptions, which doesn't seem stale yet but is
unused.
Reviewers: echristo
Subscribers: llvm-commits, mehdi_amini
Differential Revision: https://reviews.llvm.org/D31301
Modified:
llvm/trunk/include/llvm/MC/MCTargetOptions.h
llvm/trunk/include/llvm/Target/TargetOptions.h
Modified: llvm/trunk/include/llvm/MC/MCTargetOptions.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCTargetOptions.h?rev=298700&r1=298699&r2=298700&view=diff
==============================================================================
--- llvm/trunk/include/llvm/MC/MCTargetOptions.h (original)
+++ llvm/trunk/include/llvm/MC/MCTargetOptions.h Fri Mar 24 07:50:45 2017
@@ -67,31 +67,6 @@ public:
StringRef getABIName() const;
};
-inline bool operator==(const MCTargetOptions &LHS, const MCTargetOptions &RHS) {
-#define ARE_EQUAL(X) LHS.X == RHS.X
- return (ARE_EQUAL(SanitizeAddress) &&
- ARE_EQUAL(MCRelaxAll) &&
- ARE_EQUAL(MCNoExecStack) &&
- ARE_EQUAL(MCFatalWarnings) &&
- ARE_EQUAL(MCNoWarn) &&
- ARE_EQUAL(MCNoDeprecatedWarn) &&
- ARE_EQUAL(MCSaveTempLabels) &&
- ARE_EQUAL(MCUseDwarfDirectory) &&
- ARE_EQUAL(MCIncrementalLinkerCompatible) &&
- ARE_EQUAL(MCPIECopyRelocations) &&
- ARE_EQUAL(ShowMCEncoding) &&
- ARE_EQUAL(ShowMCInst) &&
- ARE_EQUAL(AsmVerbose) &&
- ARE_EQUAL(DwarfVersion) &&
- ARE_EQUAL(ABIName) &&
- ARE_EQUAL(IASSearchPaths));
-#undef ARE_EQUAL
-}
-
-inline bool operator!=(const MCTargetOptions &LHS, const MCTargetOptions &RHS) {
- return !(LHS == RHS);
-}
-
} // end namespace llvm
#endif // LLVM_MC_MCTARGETOPTIONS_H
Modified: llvm/trunk/include/llvm/Target/TargetOptions.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetOptions.h?rev=298700&r1=298699&r2=298700&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Target/TargetOptions.h (original)
+++ llvm/trunk/include/llvm/Target/TargetOptions.h Fri Mar 24 07:50:45 2017
@@ -263,43 +263,6 @@ namespace llvm {
MCTargetOptions MCOptions;
};
-// Comparison operators:
-
-
-inline bool operator==(const TargetOptions &LHS,
- const TargetOptions &RHS) {
-#define ARE_EQUAL(X) LHS.X == RHS.X
- return
- ARE_EQUAL(UnsafeFPMath) &&
- ARE_EQUAL(NoInfsFPMath) &&
- ARE_EQUAL(NoNaNsFPMath) &&
- ARE_EQUAL(NoTrappingFPMath) &&
- ARE_EQUAL(NoSignedZerosFPMath) &&
- ARE_EQUAL(HonorSignDependentRoundingFPMathOption) &&
- ARE_EQUAL(NoZerosInBSS) &&
- ARE_EQUAL(GuaranteedTailCallOpt) &&
- ARE_EQUAL(StackAlignmentOverride) &&
- ARE_EQUAL(EnableFastISel) &&
- ARE_EQUAL(UseInitArray) &&
- ARE_EQUAL(TrapUnreachable) &&
- ARE_EQUAL(EmulatedTLS) &&
- ARE_EQUAL(FloatABIType) &&
- ARE_EQUAL(AllowFPOpFusion) &&
- ARE_EQUAL(ThreadModel) &&
- ARE_EQUAL(EABIVersion) &&
- ARE_EQUAL(DebuggerTuning) &&
- ARE_EQUAL(FPDenormalMode) &&
- ARE_EQUAL(ExceptionModel) &&
- ARE_EQUAL(MCOptions) &&
- ARE_EQUAL(EnableIPRA);
-#undef ARE_EQUAL
-}
-
-inline bool operator!=(const TargetOptions &LHS,
- const TargetOptions &RHS) {
- return !(LHS == RHS);
-}
-
} // End llvm namespace
#endif
More information about the llvm-commits
mailing list