[PATCH] D30905: stable-merge-request.sh: Add a script for submitting merge requests via bugzilla

[Tom Stellard via Phabricator via llvm-commits]

tstellar marked 4 inline comments as done.
tstellar added a comment.

In https://reviews.llvm.org/D30905#709621, @hans wrote:

> One thing I just realized: the bugzilla-cli package, at least for Ubuntu, seems only available in the most recent versions: http://packages.ubuntu.com/search?keywords=bugzilla-cli (similar for Debian: https://packages.debian.org/search?keywords=bugzilla-cli)


It is available on pypi, so you can install it using pip install.  This is recommended anyway, since there is a bug with the older versions.

> At least for my work and home machines, that makes it more impractical to use, and I'm guessing that might apply to many other developers.
> 
> There seems to be a tool called "bugz" which is more widely available: http://packages.ubuntu.com/search?keywords=bugz
>  Maybe the script should use that instead, or both?

I can't find the bugz package for fedora or on pypi, so it's going to be pretty hard for me to test / use that one.



================
Comment at: utils/release/merge-request.sh:35
+  echo " -r NUM                  Revision number to merge (e.g. 1234567)."
+  echo " -project PROJECT        Revision project (e.g. clang, llvm, etc.)"
+  echo "                         use -project help for a full list of "
----------------
hans wrote:
> What does "Revision project" mean?
> 
> This seems to refer to the bugzilla Product field. Do we really care about that? Maybe to simplify this, both for the script and for the user, we could just file these bugs against the "new-bugs" product.
This is optional, and does map to bugzilla Product field.  The default is to use the new-bugs product, I thought having a project option would be useful if people wanted to be able to categorize their bugs, but I don't mind dropping this and the -component option if it helps simplify the script.


================
Comment at: utils/release/merge-request.sh:251
+
+bug_url="https://reviews.llvm.org/rL$revision"
+bug_summary="Merge r$revision into the $stable_version branch${commit_summary}"
----------------
hans wrote:
> Personally, I prefer this to point to the viewvc, but it's not important.
Is there a way to get viewvc to show you the full diff with all changes on a single page?


================
Comment at: utils/release/merge-request.sh:255
+if [ -z ${dryrun} ]; then
+  set -x
+fi
----------------
hans wrote:
> I assume this is just for your debugging?
Yes, but I think it could be useful for users to verify they've entered the correct options.


https://reviews.llvm.org/D30905