[PATCH] D31304: [MetaRenamer] Don't rename library functions.

[bryant via Phabricator via llvm-commits]

bryant added a comment.

In https://reviews.llvm.org/D31304#709318, @davide wrote:

> In https://reviews.llvm.org/D31304#709304, @bryant wrote:
>
> > What happens if there's a conflict between a meta-renamed function and originally named extern? For instance,
> >
> >   declare void @pluto()
> >  
> >   define void @dont_rename_lib_funcs(...) {  ; metarenames to pluto.
> >     ...
> >   }
> >
> >
> > ?
>
>
> If I understand your example correctly, that's a bug in the pass?


Actually, I think it would rename `dont_rename_lib_funcs` to `pluto.1, pluto.2`, etc. as it does now when it runs out of meta names (and if it doesn't, it should). What I really meant to ask is the reply above.


Repository:
  rL LLVM

https://reviews.llvm.org/D31304