[PATCH] D30152: AMDGPU/SI: Update SI scheduler colorHighLatenciesGroups

[Valery Pykhtin via Phabricator via llvm-commits]

vpykhtin added inline comments.


================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:725
+            }
+            for (SDep& PredDep : (&DAG->SUnits[k])->Preds) {
+              // We don't want any instruction which directly depend on
----------------
This loop looks the same as on line 739: how about making a function like:


```
bool hasDataDependancy(const SUnit &SU, const SUnit &FromSU) {
  for (const auto &PredDep : SU.Preds) {
      if (PredDep.getSUnit() == &FromSU && PredDep.getKind() == llvm::SDep::Data)
          return true;
  }
}
```


================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:738
+          }
+          // Same check for the SU
+          for (const SDep& PredDep : SU.Preds) {
----------------
break?


Repository:
  rL LLVM

https://reviews.llvm.org/D30152