[PATCH] D30973: [GlobalISel][X86] Support G_STORE/G_LOAD operation

[Diana Picus via Phabricator via llvm-commits]

rovka accepted this revision.
rovka added a comment.
This revision is now accepted and ready to land.

Hi,

Could you commit the unrelated changes separately (e.g. the space changes and the include reordering)?
Other than that, LGTM.



================
Comment at: lib/Target/X86/X86InstructionSelector.cpp:321
+  }
+  if (Ty == LLT::scalar(16)) {
+    if (X86::GPRRegBankID == RB.getID())
----------------
Why not else if, like the others?


================
Comment at: test/CodeGen/X86/GlobalISel/x86_64-instructionselect.mir:659
+  - { id: 0, class: gpr }
+  - { id: 1, class: vecr }
+# ALL:      %0 = COPY %rdi
----------------
Can you also add testcases for s32 and s64 living in the vecr?


Repository:
  rL LLVM

https://reviews.llvm.org/D30973