[PATCH] D31225: Use isFunctionHotInCallGraph to set the function section prefix.

Easwaran Raman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 17:09:03 PDT 2017


eraman added a comment.

LGTM after addressing the test changes.



================
Comment at: test/Transforms/CodeGenPrepare/section.ll:1
 ; RUN: opt < %s -codegenprepare -S | FileCheck %s
 
----------------
eraman wrote:
> The test needs to be updated. You've added one case - a function with cold entry with hot call edge - but the other scenarios (sum of outgoing edges is hot, cold function with non-cold outgoing edges etc) are not tested.
It's better now, but I prefer you add cases where there are multiple out edges where sum of outgoing edges is hot (and individual edges are not) and sum of outgoing edges is not cold with individual edges being cold.


https://reviews.llvm.org/D31225





More information about the llvm-commits mailing list