[PATCH] D31225: Use isFunctionHotInCallGraph to set the function section prefix.
Dehao Chen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Mar 22 15:59:54 PDT 2017
danielcdh added inline comments.
================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:128
+ if (isColdCount(FunctionCount.getValue()))
+ return true;
+
----------------
eraman wrote:
> Based on our offline conversation, I thought we want a function to be labeled only if both its entry count and the outgoing edge count sum is cold, no? With this code, a cold function can still have non-hot non-cold out edges.
>
> I think it makes sense to have
>
> coldInCallGraph => cold entry count AND cold out edges
> hotInCallGraph => hot entry count OR hot out edges.
>
> Do you agree?
You are right. Updated the code.
https://reviews.llvm.org/D31225
More information about the llvm-commits
mailing list