[PATCH] D31225: Use isFunctionHotInCallGraph to set the function section prefix.

[Easwaran Raman via Phabricator via llvm-commits]

eraman added inline comments.


================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:128
+    if (isColdCount(FunctionCount.getValue()))
+      return true;
+  
----------------
Based on our offline conversation, I thought we want a function to be labeled only if both its entry count and the outgoing edge count sum is cold, no? With this code, a cold function can still have non-hot non-cold out edges. 

I think it makes sense to have

coldInCallGraph => cold entry count AND cold out edges
hotInCallGraph => hot entry count OR hot out edges.

Do you agree?


https://reviews.llvm.org/D31225