[PATCH] D31263: Add option to control whether llvm-pdbdump outputs in color

[Zachary Turner via Phabricator via llvm-commits]

zturner accepted this revision.
zturner added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/tools/llvm-pdbdump/LinePrinter.h:27
 public:
-  LinePrinter(int Indent, raw_ostream &Stream);
+  LinePrinter(int Indent, raw_ostream &Stream, bool UseColor = true);
 
----------------
Does this need a default argument if we're always going to specify it anyway?


================
Comment at: llvm/tools/llvm-pdbdump/llvm-pdbdump.cpp:130-131
+cl::opt<cl::boolOrDefault>
+    ColorOutput("color-output", cl::desc("Use color to display the results"),
+                cl::cat(OtherOptions), cl::sub(PrettySubcommand));
 cl::list<std::string> ExcludeTypes(
----------------
We should probably come up with some wording that makes it clear that the user does not need to specify this to get color output if they're just running from the terminal.  A way to do this concisely escapes me at the moment, however.


https://reviews.llvm.org/D31263