[PATCH] D31225: Use isFunctionHotInCallGraph to set the function section prefix.

[Easwaran Raman via Phabricator via llvm-commits]

eraman added a comment.

I concur that the current state of checking the hotness of entry count is not good. I am not sure this is the right approach without seeing some numbers. Consider a function foo with calls to bar1 and bar2. Let's say foo's entry is cold. Neither foo->bar1 nor foo->bar2 is hot, but the sum of their counts is hot. Your new solution will still place foo in cold section. So may be we should add all outgoing counts and check its hotness. Even then, we may not want to put foo in cold section if the sum of outgoing edges is not cold.


https://reviews.llvm.org/D31225