[PATCH] D31147: [ELF] Allow references to reserved symbols in linker scripts

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 13:19:53 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/LinkerScript.cpp:1884
+      setError("malformed number: " + Tok);
+    Opt.Undefined.push_back(Tok);
+  }
----------------
You want to add this to `Config->Undefined` instead of your own new array.

Please add a comment saying that some special symbols (such as __ehdr_start) are defined only when there are undefined symbols for them, so we add undefined symbols to trigger that logic.


Repository:
  rL LLVM

https://reviews.llvm.org/D31147





More information about the llvm-commits mailing list