[PATCH] D31246: Send ANSI color codes only to TTYs

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

In https://reviews.llvm.org/D31246#707661, @zturner wrote:

> In https://reviews.llvm.org/D31246#707656, @chandlerc wrote:
>
> > But we use this to send color codes to temporary files that capture output for build systems and such when -fcolor-diagnostics is explicitly provided? (As an example...)
>
>
> That's strange, because everyone I asked thought that the `raw_ostream` stuff already worked this way -- i.e. doesn't send color if the destination doesn't support it.  Is there a currently accepted practice for writing FileCheck test against tools that output color?  Should every such tool have an explicit `-no-color` option?


Possibly.... What's the failure?


https://reviews.llvm.org/D31246