[PATCH] D30152: AMDGPU/SI: Update SI scheduler colorHighLatenciesGroups

[Valery Pykhtin via Phabricator via llvm-commits]

vpykhtin added inline comments.


================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:683
+      int ProposedColor = Color;
+      std::vector<int> AdditionnalElements;
+
----------------
typo


================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:720
+                 CurrentColoring[k] != 0))
+              CompatibleGroup = false;
+            for (SDep& PredDep : (&DAG->SUnits[k])->Preds) {
----------------
break?


================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:728
+                CompatibleGroup = false;
+                break;
+              }
----------------
this should also leave outer loop


================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:733
+          // Same check for the SU
+          for (const SDep& PredDep : SU.Preds) {
+            if (PredDep.getSUnit()->NodeNum == j &&
----------------
don't need to run this loop if CompatibleGroup == false


================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:736
+                PredDep.getKind() == llvm::SDep::Data)
+             CompatibleGroup = false;
+          }
----------------
break;


Repository:
  rL LLVM

https://reviews.llvm.org/D30152