[PATCH] D31148: [SDAG] Avoid deleted SDNodes PromoteIntBinOp

[Nirav Dave via Phabricator via llvm-commits]

niravd added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1099
+    SDValue NN1 = PromoteOperand(N1, PVT, Replace1);
+    SDLoc DL(Op);
 
----------------
RKSimon wrote:
> What about cases where PromoteOperand returns SDValue()? Or where N0 == N1?
The failure of PromoteOperand is an issue (fixed in new patch). If N0 == N1 (or is a subexpression), the replacement  would be invalid and will not happen. 

The SDValue check needs to be added.


https://reviews.llvm.org/D31148