[PATCH] D31242: [ARM] t2_so_imm_neg had a subtle bug in the conversion, and could trigger UB by negating (int)-2147483648. By pure luck, none of the pre-existing tests triggered this; so I'm adding one.

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 08:20:21 PDT 2017

Previous message: [PATCH] D31242: [ARM] t2_so_imm_neg had a subtle bug in the conversion, and could trigger UB by negating (int)-2147483648. By pure luck, none of the pre-existing tests triggered this; so I'm adding one.
Next message: [PATCH] D31242: [ARM] t2_so_imm_neg had a subtle bug in the conversion, and could trigger UB by negating (int)-2147483648. By pure luck, none of the pre-existing tests triggered this; so I'm adding one.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.

Right. LGTM. Thanks!


https://reviews.llvm.org/D31242

More information about the llvm-commits mailing list