[PATCH] D31148: [SDAG] Avoid deleted SDNodes PromoteIntBinOp

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 07:40:30 PDT 2017


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:1099
+    SDValue NN1 = PromoteOperand(N1, PVT, Replace1);
+    SDLoc DL(Op);
 
----------------
What about cases where PromoteOperand returns SDValue()? Or where N0 == N1?


https://reviews.llvm.org/D31148





More information about the llvm-commits mailing list