[PATCH] D31197: [ARM] Add a driver option for +no-neg-immediates

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 05:08:23 PDT 2017


rengolin added a comment.

Hi Sanne,

My point is that I think this option is not meant for user consumption, so it doesn't deserve a Clang option.

If it's useful for creating tests, or front-ends to control the target behaviour, then the target-feature is already working as expected.

The `-mllvm` should work if the option exists in the ARM back-end only (ie works on `llc` and alternatives).

Maybe it just doesn't work with `-mattr`? Have you tried directly?

All in all, unless there is a clear use case for normal users to be using this in a production environment, there is no point in passing this through Clang.

Or maybe I just don't understand what the case is, so if there is one, maybe explaining would "fix all". :)

cheers,
--renato


https://reviews.llvm.org/D31197





More information about the llvm-commits mailing list