[PATCH] D31188: [AntiDepBreaker] Do not use getPristineRegs for marking live registers.

Tim Shen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 22 00:19:20 PDT 2017


timshen marked an inline comment as done.
timshen added inline comments.


================
Comment at: llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp:166-171
+    assert(MF.getFrameInfo().isCalleeSavedInfoValid());
+    const auto &CSI = MFI.getCalleeSavedInfo();
+    return find_if(CSI.begin(), CSI.end(), [Reg](const CalleeSavedInfo &C) {
+             return C.getReg() == Reg;
+           }) != CSI.end();
+  };
----------------
qcolombet wrote:
> timshen wrote:
> > MatzeB wrote:
> > > This looks like you are replacing the check for pristine regs with manually written code that does the same. Am I missing something?
> > This is because of Quentin's comment in the bug:
> > 
> >   I would just resort on live ins information, if at all possible.
> >   If not possible I would work toward making that possible :).
> > 
> > I did it without fully understanding the big picture. :P
> > 
> > It'd be good to have you or someone explain the big picture. :)
> Yeah what I was saying is that is we can use isLiveIn alone we should do that.
> If we cannot, the long run should be to get rid of the pristine stuff (i.e., just resort on isLiveIn to convey the right information).
> I don't expect this patch to fix that :).
I see.

I was clear whether I need to do anything (e.g. remove this use site) or not. :)


https://reviews.llvm.org/D31188





More information about the llvm-commits mailing list