[llvm] r298479 - lit: remove python2-isms
Brian Gesiak via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 21 21:23:01 PDT 2017
Author: modocache
Date: Tue Mar 21 23:23:01 2017
New Revision: 298479
URL: http://llvm.org/viewvc/llvm-project?rev=298479&view=rev
Log:
lit: remove python2-isms
Summary:
`assert.assertItemEqual` went away in Python 3. Seeing how lists
are ordered, comparing a list against each other should work just
as well.
Patch by @jbergstroem (Johan Bergström).
Reviewers: modocache, gparker42
Reviewed By: modocache
Differential Revision: https://reviews.llvm.org/D31229
Modified:
llvm/trunk/utils/lit/tests/unit/TestRunner.py
Modified: llvm/trunk/utils/lit/tests/unit/TestRunner.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/unit/TestRunner.py?rev=298479&r1=298478&r2=298479&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/unit/TestRunner.py (original)
+++ llvm/trunk/utils/lit/tests/unit/TestRunner.py Tue Mar 21 23:23:01 2017
@@ -89,7 +89,7 @@ class TestIntegratedTestKeywordParser(un
parsers = self.make_parsers()
self.parse_test(parsers)
list_parser = self.get_parser(parsers, 'MY_LIST:')
- self.assertItemsEqual(list_parser.getValue(),
+ self.assertEqual(list_parser.getValue(),
['one', 'two', 'three', 'four'])
def test_commands(self):
@@ -106,7 +106,7 @@ class TestIntegratedTestKeywordParser(un
self.parse_test(parsers)
custom_parser = self.get_parser(parsers, 'MY_CUSTOM:')
value = custom_parser.getValue()
- self.assertItemsEqual(value, ['a', 'b', 'c'])
+ self.assertEqual(value, ['a', 'b', 'c'])
def test_bad_keywords(self):
def custom_parse(line_number, line, output):
More information about the llvm-commits
mailing list