[PATCH] D31226: IR: Fix a race condition in type id clients of ModuleSummaryIndex.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:530
   std::map<std::string, TypeIdSummary> TypeIdMap;
+  TypeIdSummary DefaultInitTypeIdSummary;
 
----------------
Document.

Also, it seems unusual to do this, I don't think I saw this in the past.


================
Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:711
+  }
+
   /// Remove entries in the GlobalValueMap that have empty summaries due to the
----------------
Can we use "find()" instead of "get()" and return a pointer? 


https://reviews.llvm.org/D31226