[PATCH] D30887: [ScalarEvolution] Predicate implication from operations

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy added a comment.

Did a quick rescan, LGTM again!

(You have commit access now, right?)



================
Comment at: lib/Analysis/ScalarEvolution.cpp:8550
+                                             unsigned Depth) {
+  // We want to avoid compile time hurt from analysis of too big trees.
+  if (Depth > MaxSCEVOperationsImplicationDepth)
----------------
I'd write this as "We want to avoid hurting compile time ..."


================
Comment at: lib/Analysis/ScalarEvolution.cpp:8608
+      // lead to a complex analysis of the entire graph, and in particular it
+       // can request trip count recalculation for the same loop. This would
+      // cache as SCEVCouldNotCompute to avoid the infinite recursion. This is a
----------------
Indent is off?


https://reviews.llvm.org/D30887