[PATCH] D31124: AMDGPU/SI: Add lane tracking to SI Scheduler

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:1476
+
+  for (const auto RegLaneMasks : RegWithLaneMask) {
+    SmallVector<LaneBitmask, 8> &LaneBasis =
----------------
Forgot '&'?


================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:1653
+  for (const auto RegPair : Regs) {
+    for (const auto RegPairRes : getPairsForReg(RegPair.RegUnit,
+                                                RegPair.LaneMask)) {
----------------
Can you please avoid copy here and in function's arguments?


================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:1728
     dbgs() << "\nCurrent Live:\n";
-    for (unsigned Reg : LiveRegs)
-      dbgs() << PrintVRegOrUnit(Reg, DAG->getTRI()) << ' ';
+    for (const auto RegPair : LiveRegs) {
+      dbgs() << PrintVRegOrUnit(RegPair.first, DAG->getTRI());
----------------
auto& (and in other places too)?


Repository:
  rL LLVM

https://reviews.llvm.org/D31124