[PATCH] D31217: Disable loop unrolling and icp in SamplePGO ThinLTO compile phase

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:464
+  // call promotion as it will change the CFG too much to make the 2nd
+  // profile annotation in backend more difficult.
+  if (!PerformThinLTO && !(PrepareForThinLTO && !PGOSampleUse.empty())) {
----------------
That makes me worried in some way: we're not expecting ICP and SamplePGO to be complementary from each other?


https://reviews.llvm.org/D31217