[PATCH] D31188: [AntiDepBreaker] Do not use getPristineRegs for marking live registers.

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added a comment.

I see only 5 uses of getPristineRegs, two you're removing here from the anti-dep breakers, one in MachineVerifier, and two in asserts in ARM frame lowering. Should we remove it completely? Update it with the logic you're adding here?



================
Comment at: llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp:165
+  const auto &MFI = MF.getFrameInfo();
+  const auto HasSlot = [this, &MFI](unsigned Reg) {
+    const auto &CSI = MFI.getCalleeSavedInfo();
----------------
Should this return an Optional (or similar)? It seems unfortunate to check MF.getFrameInfo().isCalleeSavedInfoValid() here and also check MFI.isCalleeSavedInfoValid() in the if below.



https://reviews.llvm.org/D31188