[PATCH] D31145: [Outliner] Fix compile-time overhead for candidate choice

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 21 02:57:38 PDT 2017


silvas added inline comments.


================
Comment at: lib/CodeGen/MachineOutliner.cpp:580
   ///
-  /// \param N The suffix tree node to start pruning from.
-  /// \param Len The length of the string to be pruned.
+  /// FIXME: We only have to look at the leaves and their parents in the tree.
+  /// We should see if it's possible to save some space in the tree by taking
----------------
silvas wrote:
> This FIXME doesn't make sense. Every internal node is the parent (not just ancestor) of a leaf. In fact you are relying on this so that looking at parents of the leaves considers all internal nodes.
> 
Or the code is failing to consider all internal nodes with this patch, which seems like a bummer. Do you have data on how many internal nodes aren't parents of leaves (and have found the missed opportunities to be negligible)?


https://reviews.llvm.org/D31145





More information about the llvm-commits mailing list