zvi added a comment. LGTM. ================ Comment at: lib/Target/X86/X86ISelLowering.cpp:34041 + + // TODO: Use PXOR + PTEST for SSE4.1 or later? + EVT VT = SetCC->getValueType(0); ---------------- Sure! And a TODO for AVX-512 https://reviews.llvm.org/D31156