[compiler-rt] r298343 - Revert "Bypass potential libc's sysconf wrappers for sysconf(_SC_PAGESIZE) call"

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 20 23:55:33 PDT 2017


Author: vitalybuka
Date: Tue Mar 21 01:55:32 2017
New Revision: 298343

URL: http://llvm.org/viewvc/llvm-project?rev=298343&view=rev
Log:
Revert "Bypass potential libc's sysconf wrappers for sysconf(_SC_PAGESIZE) call"

Bot can't find <sys/auxv.h>

This reverts commit r298305.

Removed:
    compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/sysconf_interceptor_bypass_test.cc
Modified:
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc

Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc?rev=298343&r1=298342&r2=298343&view=diff
==============================================================================
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc (original)
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc Tue Mar 21 01:55:32 2017
@@ -78,7 +78,6 @@ extern char **environ;  // provided by c
 #endif
 
 #if SANITIZER_LINUX
-#include <sys/auxv.h>
 // <linux/time.h>
 struct kernel_timeval {
   long tv_sec;
@@ -806,8 +805,6 @@ uptr GetPageSize() {
   return 4096;
 #elif SANITIZER_LINUX && (defined(__x86_64__) || defined(__i386__))
   return EXEC_PAGESIZE;
-#elif SANITIZER_LINUX
-  return getauxval(AT_PAGESZ);
 #else
   return sysconf(_SC_PAGESIZE);  // EXEC_PAGESIZE may not be trustworthy.
 #endif

Removed: compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/sysconf_interceptor_bypass_test.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/sysconf_interceptor_bypass_test.cc?rev=298342&view=auto
==============================================================================
--- compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/sysconf_interceptor_bypass_test.cc (original)
+++ compiler-rt/trunk/test/sanitizer_common/TestCases/Linux/sysconf_interceptor_bypass_test.cc (removed)
@@ -1,21 +0,0 @@
-// RUN: %clangxx -O2 %s -o %t && %run %t 2>&1 | FileCheck %s
-
-#include <stdio.h>
-
-extern "C" long sysconf(int name) {
-  fprintf(stderr, "sysconf wrapper called\n");
-  return 0;
-}
-
-int main() {
-  // All we need to check is that the sysconf() interceptor defined above was
-  // not called. Should it get called, it will crash right there, any
-  // instrumented code executed before sanitizer init is finished will crash
-  // accessing non-initialized sanitizer internals. Even if it will not crash
-  // in some configuration, it should never be called anyway.
-  fprintf(stderr, "Passed\n");
-  // CHECK-NOT: sysconf wrapper called
-  // CHECK: Passed
-  // CHECK-NOT: sysconf wrapper called
-  return 0;
-}




More information about the llvm-commits mailing list