[PATCH] D31098: [compiler-rt] respect CMAKE_EXE_LINKER_FLAGS in compiler and library tests

Chris Bieneman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 20 15:25:07 PDT 2017


beanz added inline comments.


================
Comment at: cmake/Modules/CompilerRTUtils.cmake:146
+      set(SAVED_CMAKE_EXE_LINKER_FLAGS ${CMAKE_EXE_LINKER_FLAGS})
+      set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${argstring}")
       try_compile(CAN_TARGET_${arch} ${CMAKE_BINARY_DIR} ${SIMPLE_SOURCE}
----------------
Yes, this is the right way to make this change. Can you make a similar change to `darwin_test_archs` in CompilerRTDarwinUtils.cmake?

It should be a mechanical transformation.


https://reviews.llvm.org/D31098





More information about the llvm-commits mailing list