[PATCH] D30827: [mips][msa] Prevent output operand from commuting for dpadd_[su].df instructions

[Simon Dardis via Phabricator via llvm-commits]

sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM with inline comment addressed. Don't forget to update the patch message before committing.



================
Comment at: lib/Target/Mips/MipsInstrInfo.cpp:522-525
+    unsigned CommutableOpIdx1 = MCID.getNumDefs() + 1;
+    unsigned CommutableOpIdx2 = CommutableOpIdx1 + 1;
+    if (!fixCommutedOpIndices(SrcOpIdx1, SrcOpIdx2, CommutableOpIdx1,
+                              CommutableOpIdx2))
----------------
I don't think we need to assign to CommutableOpIdx here. For these 6 cases, we know that it is always operands 2 and 3 that can be commuted.


https://reviews.llvm.org/D30827