[PATCH] D31039: [GlobalISel] Use the correct calling conv for calls

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 20 08:29:56 PDT 2017


dsanders added a comment.

In https://reviews.llvm.org/D31039#703642, @rovka wrote:

> Thanks for reviewing!
>
> I don't think it's possible to add a test using fastcc, because AArch64TargetLowering::CCAssignFnForCall returns the same calling conv for fastcc as for C, PreserveMost etc. The only ones that are different are the calling convs for WebKit_JS (but I think they're moving away from LLVM anyway) and GHC.


Ok

> I've added a test using ghccc since it's probably better to have an artificial test than no test. I'll commit on Monday if nobody comes up with a better idea.

That sounds good to me, Thanks.


Repository:
  rL LLVM

https://reviews.llvm.org/D31039





More information about the llvm-commits mailing list