[llvm] r298250 - [sancov] Fix broken links and displaced coloring in coverage-report-server.py

Maxim Ostapenko via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 20 07:06:04 PDT 2017


Author: chefmax
Date: Mon Mar 20 09:06:04 2017
New Revision: 298250

URL: http://llvm.org/viewvc/llvm-project?rev=298250&view=rev
Log:
[sancov] Fix broken links and displaced coloring in coverage-report-server.py

This patch fixes two issues:

* Fixed relative links to source files
* Enumeration of lines in source files starts from 1 instead of 0 to
  align with .symcov files generated by sancov -symbolize

Patch by Dmitiriy Nikiforov.

Differential Revision: https://reviews.llvm.org/D31038

Modified:
    llvm/trunk/tools/sancov/coverage-report-server.py

Modified: llvm/trunk/tools/sancov/coverage-report-server.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/sancov/coverage-report-server.py?rev=298250&r1=298249&r2=298250&view=diff
==============================================================================
--- llvm/trunk/tools/sancov/coverage-report-server.py (original)
+++ llvm/trunk/tools/sancov/coverage-report-server.py Mon Mar 20 09:06:04 2017
@@ -138,7 +138,7 @@ class ServerHandler(http.server.BaseHTTP
                 if not file_coverage:
                     continue
                 filelist.append(
-                        "<tr><td><a href=\"/{name}\">{name}</a></td>"
+                        "<tr><td><a href=\"./{name}\">{name}</a></td>"
                         "<td>{coverage}%</td></tr>".format(
                             name=html.escape(filename, quote=True), 
                             coverage=format_pct(file_coverage)))
@@ -165,7 +165,7 @@ class ServerHandler(http.server.BaseHTTP
                         ["<span class='{cls}'>{line} </span>".format(
                             line=html.escape(line.rstrip()), 
                             cls=linemap.get(line_no, ""))
-                            for line_no, line in enumerate(f)])
+                            for line_no, line in enumerate(f, start=1)])
 
             response = string.Template(CONTENT_PAGE_TMPL).safe_substitute(
                 path=self.path[1:],




More information about the llvm-commits mailing list