[PATCH] D27114: Preserve nonnull metadata on Loads through SROA & mem2reg.
Chandler Carruth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Mar 17 16:51:33 PDT 2017
chandlerc added a comment.
In https://reviews.llvm.org/D27114#704478, @efriedma wrote:
> I was hoping Chandler would continue to review, but I guess I can do it.
FWIW, I'm happy to continue it or for you to continue it. I was planning to GC these threads when the clang patch actually landed, but if you can get to them sooner, so much the better.
> The test here is really bare-bones; it doesn't really cover all the relevant codepaths. It doesn't check the effect of the isKnownNonNullAt, and it doesn't cover one of the codepaths in PromoteMemoryToRegister.cpp at all.
FWIW, I think this really needs to be addressed before it lands.
https://reviews.llvm.org/D27114
More information about the llvm-commits
mailing list