[PATCH] D31109: Support, LTO: Error out when pruning a directory containing files not matching a prefix.

Ivan Krasin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 16:48:05 PDT 2017


krasin added a comment.

Generally, looks good, modulo the comment.



================
Comment at: llvm/lib/Support/CachePruning.cpp:193
+    if (!Filename.startswith("llvmcache"))
+      return make_error<StringError>(
+          "unexpected file found in cache directory: " + File->path(),
----------------
We should just ignore files not created by LLVM. If a user decided to put something there, then she has a reason. And there's no actual harm to our code, if these files exist but ignored.


https://reviews.llvm.org/D31109





More information about the llvm-commits mailing list