[PATCH] D31062: PR32288: Describe a bool parameter's DWARF location with a simple register

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Took me a while to find the functional change amidst the refactoring :-)
As discussed in the PR, this LGTM, thanks!
One inline comment about a comment.



================
Comment at: lib/Transforms/Utils/Local.cpp:1118
     // describing will always be smaller than the variable size, because
     // VariableSize == Size of Alloca described by DDI. Since SI stores
     // to the alloca described by DDI, if it's first operand is an extend,
----------------
Does this comment still match our understanding?
Particularly the `The fragment we're describing will always be smaller than the variable size` bit.


https://reviews.llvm.org/D31062