[PATCH] D30827: [mips][msa] Prevent output operand from commuting for dpadd_[su].df instructions

Stefan Maksimovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 07:54:29 PDT 2017


smaksimovic updated this revision to Diff 92146.
smaksimovic retitled this revision from "[mips][msa] Disable commutativity for dpadd_[su].df instructions" to "[mips][msa] Prevent output operand from commuting for dpadd_[su].df instructions".
smaksimovic added a comment.

Hi Simon,

As per your suggestion, we've taken a look at TargetInstrInfo::commuteInstructionImpl and ended up reimplementing TargetInstrInfo::findCommutedOpIndices
for the MIPS target and handled our instructions there, keeping the isCommutable flag in the .td file.

The latter function is being called prior to the former, setting its parameters accordingly.


https://reviews.llvm.org/D30827

Files:
  lib/Target/Mips/MipsInstrInfo.cpp
  lib/Target/Mips/MipsInstrInfo.h
  test/CodeGen/Mips/msa/3r_4r_widen.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30827.92146.patch
Type: text/x-patch
Size: 10937 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170317/61c4ff74/attachment.bin>


More information about the llvm-commits mailing list