[lld] r298078 - [ELF] - Simplify logic of creating "COMMON" section.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 06:28:54 PDT 2017


>I am now getting:
>
>/home/fedora/llvm/llvm/tools/lld/ELF/Writer.cpp:361:24: warning: using the result of an assignment as a condition without >parentheses [-Wparentheses]
>
>Cheers,
>Rafael

Fixed in r298082  

It probably better then form sugested by compiler:
  if ((In<ELFT>::Common = createCommonSection<ELFT>()))
    Add(In<ELFT>::Common);

George.


More information about the llvm-commits mailing list