[lld] r297850 - [ELF] - Linkerscript: make Dot public and remove getDot(). NFC.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 05:48:51 PDT 2017


George Rimar <grimar at accesssoftek.com> writes:

>> but in this case we have a fairly complicated `setDot` function, and we always set Dot via that function. So getDot works as a >guard to protect the direct access to that variable.
>
> We don't always use setDot(), If we would do, I would not remove setter.
> We have at least 4 direct assignemt to Dot in LinkerScriptBase?. May be we should change all asignents to go through
> setDot() ?

I think that the point is that all uses outside the class have to use
setDot.

Cheers,
Rafael


More information about the llvm-commits mailing list