[PATCH] D31039: [GlobalISel] Use the correct calling conv for calls

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 17 03:06:40 PDT 2017


rovka updated this revision to Diff 92114.
rovka edited the summary of this revision.
rovka added a comment.

Thanks for reviewing!

I don't think it's possible to add a test using fastcc, because AArch64TargetLowering::CCAssignFnForCall returns the same calling conv for fastcc as for C, PreserveMost etc. The only ones that are different are the calling convs for WebKit_JS (but I think they're moving away from LLVM anyway) and GHC.

I've added a test using ghccc since it's probably better to have an artificial test than no test. I'll commit on Monday if nobody comes up with a better idea.


https://reviews.llvm.org/D31039

Files:
  include/llvm/CodeGen/GlobalISel/CallLowering.h
  lib/CodeGen/GlobalISel/CallLowering.cpp
  lib/CodeGen/GlobalISel/IRTranslator.cpp
  lib/CodeGen/GlobalISel/LegalizerHelper.cpp
  lib/Target/AArch64/AArch64CallLowering.cpp
  lib/Target/AArch64/AArch64CallLowering.h
  lib/Target/ARM/ARMCallLowering.cpp
  lib/Target/ARM/ARMCallLowering.h
  test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll
  test/CodeGen/ARM/GlobalISel/arm-irtranslator.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31039.92114.patch
Type: text/x-patch
Size: 8497 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170317/04c7698e/attachment.bin>


More information about the llvm-commits mailing list