[PATCH] D27853: [CodeGenPrep]Restructure promoting Ext to form ExtLoad

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Jun,

I think the new comments make the code more approachable. Thanks again for pushing that through.

LGTM.

Cheers,
-Quentin



================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:4564
+      Value *ExtOperand = MovedExt->getOperand(0);
+      // If we have reached to a load, we need extra this profitability check
+      // as it could potentially be merged into an ext(load).
----------------
extra this
=>
this extra


================
Comment at: lib/CodeGen/CodeGenPrepare.cpp:4565
+      // If we have reached to a load, we need extra this profitability check
+      // as it could potentially be merged into an ext(load).
+      if (isa<LoadInst>(ExtOperand) &&
----------------
The condition makes sense now


https://reviews.llvm.org/D27853