[PATCH] D31063: LTO: Fix a potential race condition in the caching API.

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 17:39:01 PDT 2017


mehdi_amini added inline comments.


================
Comment at: llvm/tools/gold/gold-plugin.cpp:835
+  auto AddBuffer = [&](size_t Task, std::unique_ptr<MemoryBuffer> MB) {
+    Filenames[Task] = MB->getBufferIdentifier();
+  };
----------------
I may comment what's going-on here though, there is an implicit expectation that the API is always backed up by a file.


https://reviews.llvm.org/D31063





More information about the llvm-commits mailing list