[llvm] r298016 - [PDB] It is not an error getting the "Invalid" Annotation opcode.

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 17:15:28 PDT 2017


Author: zturner
Date: Thu Mar 16 19:15:27 2017
New Revision: 298016

URL: http://llvm.org/viewvc/llvm-project?rev=298016&view=rev
Log:
[PDB] It is not an error getting the "Invalid" Annotation opcode.

The linker can insert invalid opcodes to indicate padding
bytes, and we should not fail in this case.

Modified:
    llvm/trunk/lib/DebugInfo/CodeView/SymbolDumper.cpp

Modified: llvm/trunk/lib/DebugInfo/CodeView/SymbolDumper.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/CodeView/SymbolDumper.cpp?rev=298016&r1=298015&r2=298016&view=diff
==============================================================================
--- llvm/trunk/lib/DebugInfo/CodeView/SymbolDumper.cpp (original)
+++ llvm/trunk/lib/DebugInfo/CodeView/SymbolDumper.cpp Thu Mar 16 19:15:27 2017
@@ -468,8 +468,8 @@ Error CVSymbolDumperImpl::visitKnownReco
   for (auto &Annotation : InlineSite.annotations()) {
     switch (Annotation.OpCode) {
     case BinaryAnnotationsOpCode::Invalid:
-      return llvm::make_error<CodeViewError>(
-          "Invalid binary annotation opcode!");
+      W.printString("(Annotation Padding)");
+      break;
     case BinaryAnnotationsOpCode::CodeOffset:
     case BinaryAnnotationsOpCode::ChangeCodeOffset:
     case BinaryAnnotationsOpCode::ChangeCodeLength:




More information about the llvm-commits mailing list