[PATCH] D30959: [pdb] Add support for writing Module Info and module symbols

[Zachary Turner via Phabricator via llvm-commits]

zturner added inline comments.


================
Comment at: llvm/tools/llvm-pdbdump/llvm-pdbdump.cpp:374
 
-  ExitOnErr(Builder.initialize(YamlObj.Headers->SuperBlock.BlockSize));
+  uint32_t BlockSize = 4096;
+  if (YamlObj.Headers.hasValue())
----------------
ruiu wrote:
> It may be nice to leave a comment about 4096. It's just a reasonable default block size for a PDB file and used if a YAML file doesn't specify any block size, right?
Yes.  It's also what you get in almost every Microsoft generated PDB that I've seen.


https://reviews.llvm.org/D30959