[PATCH] D31011: recommend using llvm-ar when finding undefined references and empty archives

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/InputFiles.cpp:565
+
+  if (NoSymbols) Config->ArchiveWithoutSymbolsSeen = true;
 }
----------------
inglorion wrote:
> davide wrote:
> > ruiu wrote:
> > > Format.
> > > 
> > > Let's eliminate the local varaible. You could replace `NoSymbols` with `File->symbols().empty()`. `File->symbols()` is cheap so you don't need to save time here.
> > should live on two different lines, no? (in general, clang-format).
> W.r.t. "two different lines": that's what I thought, too, but clang-format actually changed it to be one line. Shall I just go ahead and change it back to two lines?
You want to make sure that you are using the LLVM style when formatting it with clang-format. Clang-format reflowed this line to use two lines for me.


https://reviews.llvm.org/D31011