[PATCH] D30699: [ELF] - Stop producing broken output for R_386_GOT32X relocation.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 16:22:33 PDT 2017


ruiu added a comment.

My apologies, but I'm really confused by your conflicting responses about this patch.

H.J. Lu said that GOT and GOTX are handled as the same relocation if linkers decide to not optimize them. You agreed with that. Therefore, I suggested handling them as the same relocation, because that's at least not wrong. And then you are saying that that is wrong. Your explanation is too detailed, and I don't get the gist of that. Simply put, is H.J. Lu.'s comment wrong?


https://reviews.llvm.org/D30699





More information about the llvm-commits mailing list