[PATCH] D30317: [X86] Clean up test/CodeGen/X86/2006-03-01-InstrSchedBug.ll

Jorge Gorbe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 16:01:30 PDT 2017


jgorbe updated this revision to Diff 92081.
jgorbe added a comment.

- Regenerated the test with update_llc_test_checks.py
- Specified target triple in the RUN: line with -mtriple
- Removed entry label added in the previous version of the patch.

Thanks for the review! (and sorry it took me so long to respond)


https://reviews.llvm.org/D30317

Files:
  test/CodeGen/X86/2006-03-01-InstrSchedBug.ll


Index: test/CodeGen/X86/2006-03-01-InstrSchedBug.ll
===================================================================
--- test/CodeGen/X86/2006-03-01-InstrSchedBug.ll
+++ test/CodeGen/X86/2006-03-01-InstrSchedBug.ll
@@ -1,12 +1,26 @@
-; RUN: llc < %s -march=x86 | not grep "subl.*%esp"
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -march=x86 | FileCheck %s
+
+target triple = "i686-unknown-unknown"
 
 define i32 @f(i32 %a, i32 %b) {
-        %tmp.2 = mul i32 %a, %a         ; <i32> [#uses=1]
-        %tmp.5 = shl i32 %a, 1          ; <i32> [#uses=1]
-        %tmp.6 = mul i32 %tmp.5, %b             ; <i32> [#uses=1]
-        %tmp.10 = mul i32 %b, %b                ; <i32> [#uses=1]
-        %tmp.7 = add i32 %tmp.10, %tmp.2                ; <i32> [#uses=1]
-        %tmp.11 = add i32 %tmp.7, %tmp.6                ; <i32> [#uses=1]
-        ret i32 %tmp.11
+; CHECK-LABEL: f:
+; CHECK:       # BB#0:
+; CHECK-NEXT:    movl {{[0-9]+}}(%esp), %eax
+; CHECK-NEXT:    movl {{[0-9]+}}(%esp), %ecx
+; CHECK-NEXT:    movl %ecx, %edx
+; CHECK-NEXT:    imull %edx, %edx
+; CHECK-NEXT:    imull %eax, %ecx
+; CHECK-NEXT:    imull %eax, %eax
+; CHECK-NEXT:    addl %edx, %eax
+; CHECK-NEXT:    leal (%eax,%ecx,2), %eax
+; CHECK-NEXT:    retl
+  %tmp.2 = mul i32 %a, %a
+  %tmp.5 = shl i32 %a, 1
+  %tmp.6 = mul i32 %tmp.5, %b
+  %tmp.10 = mul i32 %b, %b
+  %tmp.7 = add i32 %tmp.10, %tmp.2
+  %tmp.11 = add i32 %tmp.7, %tmp.6
+  ret i32 %tmp.11
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30317.92081.patch
Type: text/x-patch
Size: 1496 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170316/b1ed1772/attachment.bin>


More information about the llvm-commits mailing list