[PATCH] D30438: SplitKit: Correctly implement partial copies

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 15:55:36 PDT 2017


qcolombet accepted this revision.
qcolombet added a comment.

LGTM with more checks in the test.



================
Comment at: test/CodeGen/AMDGPU/splitkit.mir:35
+# in between for the two subregisters that are alive.
+# CHECK-LABEL: name: func1
+name: func1
----------------
MatzeB wrote:
> kparzysz wrote:
> > This is the only CHECK like in this function.  Did it use to crash?
> This should indeed have more CHECKs. I'll add them.
Please add more checks indeed.


Repository:
  rL LLVM

https://reviews.llvm.org/D30438





More information about the llvm-commits mailing list