[lld] r297844 - [ELF] - Split struct In<ELFT> to have templated and non-templated sections areas.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 16 15:52:24 PDT 2017


I think I don't like neither, as neither don't demonstrate what we can get
from these changes.

On Thu, Mar 16, 2017 at 1:05 AM, George Rimar <grimar at accesssoftek.com>
wrote:

> >Please do not use inheritance. You don't need that at all here.
>
> So do you prefer approach used in first version of patch ? (
> https://reviews.llvm.org/D30939?id=91714),
> ​it did not use inheritance but changed much more places in code.
>
> George.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170316/f299c949/attachment.html>


More information about the llvm-commits mailing list